New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix baseurl for Favicon and Apple icons #371

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@ashawley
Collaborator

ashawley commented Dec 3, 2018

Currently, the favicons and Apple touch icons are assumed to be in the server root directory. This won't work with baseurl. We need to add an element for favicon.ico, so that it's location could be overridden.

This is similar to the fix for #370.

@johno

johno approved these changes Dec 3, 2018

📲

@ashawley ashawley force-pushed the ashawley:baseurl-favicon branch from ba621bd to 4695cc6 Dec 5, 2018

@ashawley ashawley merged commit 0cdd295 into johno:master Dec 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashawley ashawley deleted the ashawley:baseurl-favicon branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment