Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds benchmark.py script #18

Closed
wants to merge 1 commit into from
Closed

Adds benchmark.py script #18

wants to merge 1 commit into from

Conversation

robmarkcole
Copy link
Collaborator

Addresses #14
Placed in test directory as there are already images there. This shouldnt affect the test run as the filename doesn't begin with test.

@robmarkcole
Copy link
Collaborator Author

@johnolafenwa I want to improve this to also calculate an accuracy metric, something mAP@95. Any suggestions?

@johnolafenwa
Copy link
Owner

@robmarkcole , i will review the steps to add AP evaluating and revert back. It might be a little tricky but it is possible

@robmarkcole robmarkcole linked an issue Nov 2, 2020 that may be closed by this pull request
@johnolafenwa
Copy link
Owner

@robmarkcole There are conflicts in merging this. Please review

@robmarkcole
Copy link
Collaborator Author

hmm followed the instructions but cannot see the conflict

@robmarkcole
Copy link
Collaborator Author

I actually now think this shouldn't be part of Dee-stack, but part of a separate utils library.
Given this, and the conflict I cannot see, I will close this PR and we can have a discussion about where it should live

@robmarkcole
Copy link
Collaborator Author

robmarkcole commented Nov 16, 2020

Oh I see the merge conflict was because you already merged it, somehow

@johnolafenwa
Copy link
Owner

I see that, we can take out later and add it to the utils.

johnolafenwa added a commit that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeepStack Benchmark Script
2 participants