Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data service bugs; add timeout #95

Merged
merged 1 commit into from
Dec 22, 2017
Merged

fix data service bugs; add timeout #95

merged 1 commit into from
Dec 22, 2017

Conversation

wardbell
Copy link
Collaborator

@wardbell wardbell commented Dec 22, 2017

Fixed numerous bugs in the data service area discovered while adding timeout to the data service including:

  • comments in dispatcher said the exact opposite of what is going on
  • used entity.id when the PK might be named something else (must use selectId().
  • wrong method return types
  • passed arg to getAll that does nothing.
  • now pass more useful info about the request (RequestData) to handleError for debugging.

Why did I add timeout in the first place? Because it hung today, trying to reach the remote and I had locked up processes everywhere. The timeout would free to the app to keep going (and you can go back to local).

I looked into cancel for a while. Don't know how the user would call it. So that's a future.

@wardbell wardbell self-assigned this Dec 22, 2017
Copy link
Owner

@johnpapa johnpapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@johnpapa johnpapa merged commit db17b99 into master Dec 22, 2017
@johnpapa johnpapa deleted the fix-data-service branch December 22, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants