Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed numerous bugs in the data service area discovered while adding
timeout
to the data service including:entity.id
when the PK might be named something else (must useselectId()
.getAll
that does nothing.RequestData
) tohandleError
for debugging.Why did I add
timeout
in the first place? Because it hung today, trying to reach the remote and I had locked up processes everywhere. The timeout would free to the app to keep going (and you can go back to local).I looked into cancel for a while. Don't know how the user would call it. So that's a future.