Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eating one's own dog food #764

Closed
sgbeal opened this issue Aug 31, 2016 · 7 comments
Closed

Eating one's own dog food #764

sgbeal opened this issue Aug 31, 2016 · 7 comments

Comments

@sgbeal
Copy link

sgbeal commented Aug 31, 2016

The style guide lost me at:

"Note: For brevity only, the rest of the examples in this guide may omit the IIFE syntax."

at which point i was reminded of a quote by Jon Stewart:

"If you don't stick to your values when they're being tested, they're not values: they're hobbies."

and, as so many parents and teachers like to say:

"Do as I say, not as I do."

It's difficult to take a self-help guide seriously when it refuses to follow its own advice. There's no reason (especially not brevity) the style guide should be exempt from its own advice.

Something to consider.

@jeanvillete
Copy link

Really?

Are you claiming because you didn't understand the examples or because you
don't know IIFE syntax?

"Note: For brevity only, it is a style guide (the best one) and just it,
but it looks like someone is looking for a code in order to just copy it..."

On Wed, Aug 31, 2016 at 5:00 AM, Stephan Beal notifications@github.com
wrote:

The style guide lost me at:

"Note: For brevity only, the rest of the examples in this guide may omit
the IIFE syntax."

at which point i was reminded of a quote by Jon Stewart:

"If you don't stick to your values when they're being tested, they're not
values: they're hobbies."

and, as so many parents and teachers like to say:

"Do as I say, not as I do."

It's difficult to take a self-help guide seriously when it refuses to
follow its own advice. There's no reason (especially not brevity) the style
guide should be exempt from its own advice.

Something to consider.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#764, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AGl-P3BFK86yuVGlUTr5ViPH6UMXXv9Jks5qlTSUgaJpZM4JxVWx
.

Best regards.

Jean Bruno Souto Villete (+55 15 8173 4146)

http://about.me/jeanbruno
http://br.linkedin.com/in/jeanvillete
http://br.linkedin.com/in/jeanbrunoti/
http://jeanvillete.blogspot.com

@sgbeal
Copy link
Author

sgbeal commented Aug 31, 2016

Seriously, i don't understand the examples? i've been programming since the early 1980s, JavaScript for nearly 20 years, and i've authored more than one scripting language myself.

i'm stating that if the author(s) cannot be bothered to follow his/their own advice, he/they should not bother writing that advice.

End of story.

@sgbeal sgbeal closed this as completed Aug 31, 2016
@gkalpak
Copy link

gkalpak commented Aug 31, 2016

Fwiw, I appreciate the brevity. I am glad I don't have to deal with the IIFE "noise" when is irrelevant to the example at hand.

@mikeerickson
Copy link

Now now kids, lets be nice to one another. Taking into account

  • @johnpapa is an awesome person in the community
  • @johnpapa is try to make the angular community a better place
  • @johnpapa is bald which gives him 10 extra do whatever he wants points

It is a soft guideline, not a rule. If you don't like something in the guide, simply gloss over it and move on. No sense in attacking him.

@kylecordes
Copy link

@johnpapa is my favorite person also :-) but in the defense of the OP, we went through these same issues with our class curriculum, and decided, at least for A1 JS code, to follow the style guide and use IIFEs everywhere even in tiny single-purpose example programs. We found that by doing so, learners much more effectively absorb the idea of coding according to the guide and according to common conventions therein. It is a bit of visual noise, but probably worthwhile overall.

@mikeerickson
Copy link

I too follow the IIFE pattern for all angular 1 dev. I was more commenting on the flame from @sgbeal There are better and more productive ways to articulate ones point, being rude is not the way. It is posts like this that give OSS devs a bad taste. I just cant fathom how someone getting something for free can do this.

@johnpapa
Copy link
Owner

johnpapa commented Sep 3, 2016

There is an easy solution ... make a PR (150+ others have) :)

@kylecordes and @mikeerickson and thanks for the positive vibes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants