New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover and sheet not working on iOS 14.2 (Sim) #12
Comments
Thanks for raising this issue, I'm glad you like the library. I understand there was a bug in SwiftUI in iOS 14 that is fixed in iOS 14.5 upwards:
I think it makes sense for this library to work around the issue; I'll have a look. Thanks! |
Thanks for the quick reply! Interesting. I just downloaded the 14.5 simulator runtime. In fact the problem disappears. |
Unfortunately I hit issues when trying to work around this issue. For example, I tried variations on this theme to avoid chaining
That works around the issue on iOS 14.4 and below, but introduces a bug (even on iOS 15), where presenting a screen five layers of presentation deep fails with this error:
Instead, conditionally applying only one of the modifiers (#13) seems to work around the issue without introducing any regressions. Sadly, on iOS 14.4 and below, the I'll continue to check the solution works well before merging... |
Thank you for the investigation @johnpatrickmorgan 🙏🏻 |
Thanks for solving it! |
Hi, let me first say, I love your approach. ViewModifier stack plus array of routes representing it. That is the best and most solid approach I have seen. Really nice when refactoring code.
Problem found: I cannot get the sheets to work in iOS 14.2. It applies to the fullscreen cover, too – however, not in 100% of cases. Problem applies to my own code, but also when I build your example code. Tested only in 14.2, not 14.x so far.
Regards
The text was updated successfully, but these errors were encountered: