feat: remove npm birthday (npm#5455)

BREAKING CHANGE: this removes the `npm birthday` command
johnperez416 · Sep 8, 2022 · 49bbb2f · 49bbb2f
1 parent 285b39f
commit 49bbb2f
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 45 deletions.
diff --git a/lib/commands/birthday.js b/lib/commands/birthday.js
diff --git a/lib/utils/cmd-list.js b/lib/utils/cmd-list.js
@@ -138,7 +138,7 @@ const cmdList = [
   'whoami',
 ]
 
-const plumbing = ['birthday', 'help-search']
+const plumbing = ['help-search']
 const abbrevs = abbrev(cmdList.concat(Object.keys(aliases)))
 
 module.exports = {

diff --git a/tap-snapshots/test/lib/load-all-commands.js.test.cjs b/tap-snapshots/test/lib/load-all-commands.js.test.cjs
@@ -57,15 +57,6 @@ Options:
 Run "npm help audit" for more info
 `
 
-exports[`test/lib/load-all-commands.js TAP load each command birthday > must match snapshot 1`] = `
-Birthday, deprecated
-
-Usage:
-npm birthday
-
-Run "npm help birthday" for more info
-`
-
 exports[`test/lib/load-all-commands.js TAP load each command bugs > must match snapshot 1`] = `
 Report bugs for a package in a web browser
 

diff --git a/tap-snapshots/test/lib/utils/cmd-list.js.test.cjs b/tap-snapshots/test/lib/utils/cmd-list.js.test.cjs
@@ -474,7 +474,6 @@ Object {
     "whoami",
   ],
   "plumbing": Array [
-    "birthday",
     "help-search",
   ],
 }

diff --git a/test/lib/commands/birthday.js b/test/lib/commands/birthday.js
diff --git a/test/lib/npm.js b/test/lib/npm.js
@@ -574,10 +574,10 @@ t.test('aliases and typos', async t => {
   const { npm } = await loadMockNpm(t, { load: false })
   await t.rejects(npm.cmd('thisisnotacommand'), { code: 'EUNKNOWNCOMMAND' })
   await t.rejects(npm.cmd(''), { code: 'EUNKNOWNCOMMAND' })
-  await t.rejects(npm.cmd('birt'), { code: 'EUNKNOWNCOMMAND' })
+  await t.rejects(npm.cmd('birthday'), { code: 'EUNKNOWNCOMMAND' })
   await t.resolves(npm.cmd('it'), { name: 'install-test' })
   await t.resolves(npm.cmd('installTe'), { name: 'install-test' })
-  await t.resolves(npm.cmd('birthday'), { name: 'birthday' })
+  await t.resolves(npm.cmd('access'), { name: 'access' })
 })
 
 t.test('explicit workspace rejection', async t => {