Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip #8

Closed
NawafKi opened this issue Sep 9, 2021 · 14 comments
Closed

Tooltip #8

NawafKi opened this issue Sep 9, 2021 · 14 comments
Labels
wishlist nice to haves

Comments

@NawafKi
Copy link

NawafKi commented Sep 9, 2021

Is There anyway to hide the directory path in the tooltip ?

@johnpierson
Copy link
Owner

johnpierson commented Sep 9, 2021

not at this time. we can try looking at adding an option in future releases that reads the description of the dynamo graph. (new feature in Dynamo 2.12)

@johnpierson johnpierson added wontfix This will not be worked on wishlist nice to haves and removed wontfix This will not be worked on labels Sep 9, 2021
@brencass
Copy link

brencass commented Jan 1, 2022

@johnpierson Have a look at my recent fork variation that could help to add this feature to all Dynamo Scripts irrespective of if they are Dynamo 2.12 or not. The dynamo 2.12 description could be additionally added. It does require the scripts to having a specific "note" within the script to work in a similar way to using a scripting template that includes additional notes for information purposes. Though if it does not find this it will revert back to original implementation.

Note:

  • Do not take all of the full branch because i modified the project file to include nuget packages.
  • You will need to add "Newtonsoft.Json" reference.
  • You will need to add "Microsoft.Csharp" reference.
  • I have added/modified scripts to show how this can be added to a file.

Image 1:
image

Image 2:
image

Folder Organisation for the above two image:
image

Example Data within Script:
image

My fork variation: https://github.com/brencass/Relay/tree/ReadsDescriptionFromWithinFile

@johnpierson
Copy link
Owner

Hmm. I'll have to take a look and I like the idea.

However, I would really like to support the 2.12 properties first, the custom note second and default file path if those two are not present

@brencass
Copy link

brencass commented Jan 1, 2022

I agree that the new 2.12 feature for description property should take precedence over other things but what I have added should give a good enough starting part :)

@johnpierson
Copy link
Owner

Definitely! I appreciate your contribution too and I'll get that pulled over along with the other options. 😁

happy new year!

@brencass
Copy link

brencass commented Jan 1, 2022

No worries, good to contribute a thought with the code implementation :)

Happy new year to you too!

@brencass
Copy link

brencass commented Jan 2, 2022

Added the ability for Dynamo 2.12 and above description to be used and is used as a preference if it is not empty("") on my fork :)

https://github.com/brencass/Relay/tree/ReadsDescriptionFromWithinFile

@johnpierson
Copy link
Owner

johnpierson commented Jan 6, 2022

@brencass I checked on this and the description in the DYN json exists (and persists) all the way back to at least Dynamo 2.0.4
image
in this image i added that description in 2.12, opened in 2.0.4 and saved it and it lasts throughout

The UI modification of it was introduced in 2.12 making it easier. For older versions if you edit the .dyn as text it works.

This would mean that the modern description could be the tooltip (and the URL parameter introduced in 2.12 can be the F1 help in the future).

Extending this with the notes is interesting, but this functionality being built-in to the .dyn itself is what is very interesting to me.

@brencass
Copy link

brencass commented Jan 9, 2022

@johnpierson This changes the game a little bit and maybe it should "check" if it can find the description property instead of the dynamo version. Then if this is null or " " then it will use the notes and as a last resort is the original way.

Adding the F1 help part should be a easy to add into the code.

I just tried to see if you add other properties manually into a dyn file if they are kept past a re-save, bad news is that they are not :(.

@johnpierson
Copy link
Owner

johnpierson commented Jan 9, 2022 via email

@chuncahk
Copy link

chuncahk commented Aug 9, 2022

Can this problem be solved by adding a txt file along with the dyn script?
if no txt presented, then it will shows the path by default

@johnpierson
Copy link
Owner

Hi @chunchk , When I get this feature added it will utilize the built-in graph description introduced in Dynamo 2.12, first. For versions prior to 2.12, I do like the txt idea because that does not require the plugin to search for a specific note. Let me ponder on that a bit more.

@johnpierson
Copy link
Owner

So here is a quick mockup of what I was thinking for all currently supported Revit versions for relay (Revit 2021 - 2023).

The description is available in Dynamo's UI now through the Graph Properties extension.
image

And this would result in this:
image

The part of this that is required moving forward (and backward) is I have to have the file path in the tooltip with how relay loads a DYN right now.

Once again, this would work for Revit 2021 - 2023. Any older than that, the tooltips would not show up.

@bobarakatx
Copy link

bobarakatx commented Mar 18, 2024

This is not working in the latest Relay version. Revit 2023.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist nice to haves
Projects
None yet
Development

No branches or pull requests

5 participants