Gradle 2.0 Compatibility #66

Closed
ArabMegadeth opened this Issue Jul 1, 2014 · 8 comments

Comments

Projects
None yet
4 participants
@ArabMegadeth

Shadow plugin version 1.0.1 is using an internal Gradle api class: org.gradle.api.internal.file.copy.CopySpecInternal in the class com.github.jengelman.gradle.plugins.shadow.internal.DependencyFilter.
This internal Gradle class is removed from Gradle 2.0 which was release at July 1st 2014, making shadow unusable with Gradle 2.0.

@johnrengelman johnrengelman added the bug label Jul 1, 2014

@johnrengelman johnrengelman added this to the 1.1.0 milestone Jul 1, 2014

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Jul 1, 2014

Owner

Is this the error that you get?

> No signature of method: org.gradle.api.internal.file.copy.DefaultCopySpec_Decorated.getPatternSet() is applicable for argument types: () values: []

That class still exists in Gradle 2.0: https://github.com/gradle/gradle/blob/REL_2.0/subprojects/core/src/main/groovy/org/gradle/api/internal/file/copy/CopySpecInternal.java

Owner

johnrengelman commented Jul 1, 2014

Is this the error that you get?

> No signature of method: org.gradle.api.internal.file.copy.DefaultCopySpec_Decorated.getPatternSet() is applicable for argument types: () values: []

That class still exists in Gradle 2.0: https://github.com/gradle/gradle/blob/REL_2.0/subprojects/core/src/main/groovy/org/gradle/api/internal/file/copy/CopySpecInternal.java

@ArabMegadeth

This comment has been minimized.

Show comment
Hide comment
@ArabMegadeth

ArabMegadeth Jul 1, 2014

I do get this error.

I do get this error.

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Jul 1, 2014

Owner

Hmm, ok. Looks like the internal api masking got stricter and is restricting access to that method now.
Thanks for the report!

Owner

johnrengelman commented Jul 1, 2014

Hmm, ok. Looks like the internal api masking got stricter and is restricting access to that method now.
Thanks for the report!

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Jul 1, 2014

Owner

I think I can replace this with just PatternSet which would be a much better option.

Owner

johnrengelman commented Jul 1, 2014

I think I can replace this with just PatternSet which would be a much better option.

@ArabMegadeth

This comment has been minimized.

Show comment
Hide comment
@ArabMegadeth

ArabMegadeth Jul 1, 2014

Happy to Help!

Happy to Help!

@DmitriyMV

This comment has been minimized.

Show comment
Hide comment
@DmitriyMV

DmitriyMV Jul 2, 2014

How soon it will be ready? 1.1.0 seems to be far enough.

How soon it will be ready? 1.1.0 seems to be far enough.

@johnrengelman

This comment has been minimized.

Show comment
Hide comment
@johnrengelman

johnrengelman Jul 2, 2014

Owner

Hopefully only a couple days. Please remember that this is a side project for me.

Owner

johnrengelman commented Jul 2, 2014

Hopefully only a couple days. Please remember that this is a side project for me.

@zfy0701

This comment has been minimized.

Show comment
Hide comment
@zfy0701

zfy0701 Jul 4, 2014

thanks for fixing this! it would be great to see the new release in jcenter soon!

zfy0701 commented Jul 4, 2014

thanks for fixing this! it would be great to see the new release in jcenter soon!

@johnrengelman johnrengelman modified the milestones: 1.0.2 - Bug fixes, 1.0.1 Jul 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment