Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 2.0 Compatibility #66

Closed
ArabMegadeth opened this issue Jul 1, 2014 · 8 comments
Closed

Gradle 2.0 Compatibility #66

ArabMegadeth opened this issue Jul 1, 2014 · 8 comments
Labels

Comments

@ArabMegadeth
Copy link

Shadow plugin version 1.0.1 is using an internal Gradle api class: org.gradle.api.internal.file.copy.CopySpecInternal in the class com.github.jengelman.gradle.plugins.shadow.internal.DependencyFilter.
This internal Gradle class is removed from Gradle 2.0 which was release at July 1st 2014, making shadow unusable with Gradle 2.0.

@johnrengelman johnrengelman added this to the 1.1.0 milestone Jul 1, 2014
@johnrengelman
Copy link
Owner

Is this the error that you get?

> No signature of method: org.gradle.api.internal.file.copy.DefaultCopySpec_Decorated.getPatternSet() is applicable for argument types: () values: []

That class still exists in Gradle 2.0: https://github.com/gradle/gradle/blob/REL_2.0/subprojects/core/src/main/groovy/org/gradle/api/internal/file/copy/CopySpecInternal.java

@ArabMegadeth
Copy link
Author

I do get this error.

@johnrengelman
Copy link
Owner

Hmm, ok. Looks like the internal api masking got stricter and is restricting access to that method now.
Thanks for the report!

@johnrengelman
Copy link
Owner

I think I can replace this with just PatternSet which would be a much better option.

@ArabMegadeth
Copy link
Author

Happy to Help!

@DmitriyMV
Copy link

How soon it will be ready? 1.1.0 seems to be far enough.

@johnrengelman
Copy link
Owner

Hopefully only a couple days. Please remember that this is a side project for me.

@zfy0701
Copy link

zfy0701 commented Jul 4, 2014

thanks for fixing this! it would be great to see the new release in jcenter soon!

@johnrengelman johnrengelman modified the milestones: 1.0.2 - Bug fixes, 1.0.1 Jul 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants