Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix excludes ant pattern on Windows #539

Merged
merged 1 commit into from Jan 19, 2020
Merged

Fix excludes ant pattern on Windows #539

merged 1 commit into from Jan 19, 2020

Conversation

trask
Copy link
Contributor

@trask trask commented Jan 16, 2020

Fixes this use case on Windows:

  relocate('io.opentelemetry', 'io.opentelemetry.auto.shaded.io.opentelemetry') {
    exclude 'io.opentelemetry.auto.**'
  }

The fix is to explicitly pass separator (/) to SelectorUtils.matchPath. The default when it's not passed is File.separator, so this change should have no effect on non-Windows OS.

@trask trask mentioned this pull request Jan 16, 2020
Merged
@johnrengelman johnrengelman merged commit d9567dd into johnrengelman:master Jan 19, 2020
@trask
Copy link
Contributor Author

trask commented Jan 20, 2020

Thx!

@johnrengelman johnrengelman added this to the 6.0 milestone Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnrengelman johnrengelman johnrengelman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trask @johnrengelman