Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protected superclass fields via super because of GROOVY-9292 #655

Merged
merged 1 commit into from Mar 30, 2021
Merged

Use protected superclass fields via super because of GROOVY-9292 #655

merged 1 commit into from Mar 30, 2021

Conversation

m8nmueller
Copy link
Contributor

The use of the abstract fields in the ServiceFileTransformer without super results in an error in newer Groovy versions since PR 1050. For the current Gradle 7.0 RC, that looks like this:

Caused by: groovy.lang.MissingPropertyException: No such property: count for class: com.github.jengelman.gradle.plugins.shadow.transformers.ServiceFileTransformer
        at com.github.jengelman.gradle.plugins.shadow.transformers.ServiceFileTransformer$ServiceStream.append(ServiceFileTransformer.groovy:110)
        at ...

Apart from that, the plugin is usable with Gradle 7.0, as far as I can tell.

@johnrengelman johnrengelman added this to the 6.2 milestone Mar 30, 2021
@johnrengelman johnrengelman merged commit 37fcc73 into johnrengelman:master Mar 30, 2021
@m8nmueller m8nmueller mentioned this pull request Apr 8, 2021
Closed
@breskeby
Copy link

Any concrete plans for the 6.2 release?

@johnrengelman
Copy link
Owner

Working on it now Rene.

breskeby added a commit to breskeby/elasticsearch that referenced this pull request Apr 26, 2021
@breskeby
Temporarilly use shadowplugin 6.2 snapshot version
cf9dd18 
This fixes a gradle 7.0 incompatibility with the shadow plugin 6.1
see johnrengelman/shadow#655 for details
@breskeby breskeby mentioned this pull request Apr 26, 2021
Closed
@breskeby
Copy link

breskeby commented Apr 26, 2021 via email

@sdedic sdedic mentioned this pull request Apr 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m8nmueller @breskeby @johnrengelman