Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Spock tests run again #672

Merged
merged 1 commit into from Aug 1, 2021

Conversation

helfper
Copy link
Contributor

@helfper helfper commented May 23, 2021

Spock tests haven't been running since the migration to Spock 2. This PR fixes that.

@@ -1103,7 +1073,7 @@ class ShadowPluginSpec extends PluginSpecification {
mainClassName = 'myapp.Main'

dependencies {
compile 'shadow:a:1.0'
implemnetation 'shadow:a:1.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed now.

@johnrengelman johnrengelman added this to the 7.1 milestone Aug 1, 2021
@johnrengelman johnrengelman merged commit a49d2ef into johnrengelman:master Aug 1, 2021
@helfper helfper deleted the fix-spock-tests branch August 1, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants