Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RelocatorRemapper: do not map inner class name if not changed #793

Merged

Conversation

Him188
Copy link
Contributor

@Him188 Him188 commented Sep 16, 2022

Fixes #792

@Him188
Copy link
Contributor Author

Him188 commented Sep 17, 2022

Note that the relevant PR for asm has been merged. When a new version of asm with this commit is published, we can simply upgrade to the new version.

@johnrengelman johnrengelman modified the milestones: 8.0, Next, 8.1.0 Feb 24, 2023
@johnrengelman johnrengelman merged commit a32da02 into johnrengelman:master Feb 26, 2023
@Him188 Him188 deleted the dont-remap-same-inner-class-names branch February 27, 2023 00:10
@ArcticLampyrid
Copy link
Contributor

not necessary to merge

we've upgradled to asm v9.4, and this is fixed by upstream.

2 October 2022: ASM 9.4 (tag ASM_9_4)

  • new Opcodes.V20 constant for Java 20
  • more checks in CheckClassAdapter
  • Javadoc improvements and fixes
  • module-info classes can be built without Gradle and Bnd
  • parent POM updated to org.ow2:ow2:1.5.1
  • bug fixes
    • 317977: CheckClassAdapter is no longer transparent for MAXLOCALS
    • 317981: Add public getDelegate method to all visitor classes
    • Analyzer does not compute optimal maxLocals for static methods
    • Fix SignatureWriter when a generic type has a depth over 30
    • Skip remap inner class name if not changed in Remapper

@johnrengelman
Copy link
Owner

Reverting this in 8.1.1.
Thanks @ArcticLampyrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relocation breaks inner classes which contains '$' in name
3 participants