-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(page): Add page navigation button #2142
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Someone is attempting to deploy a commit to the JNJ Demo Account Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for creating a pull request on GitHub! We appreciate your contribution to our repository. In order to enable our tests to run on your changes, we kindly ask that you wait until one of our repository members adds the ready-to-test label to your pull request. (Please request on the GitHub issue you are addressing.) This will ensure that our testing process runs smoothly and we can quickly verify the changes you've made. Thank you for your understanding and we look forward to reviewing your changes soon! |
@@ -166,6 +167,7 @@ const getStaticProps = async ({ params }: getServerSideProps) => { | |||
try { | |||
const indexPath = findComponentPath(...pagesBasePath, ...realSlug.split('/').filter(Boolean)); | |||
if (indexPath === null) { | |||
// eslint-disable-next-line no-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor — there is already a disable rule for it at the top.
@@ -0,0 +1,28 @@ | |||
export type TreeNode = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add License for new file
url?: string, | ||
}; | ||
|
||
export function pathsToTree(paths: string[] = []) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use arrow function for consistent?
|
||
const FolderTree: FC<FolderTreeProps> = props => { | ||
const { ComponentFormList } = usePageMenuOptionUI(); | ||
// const ComponentFormList = 'ul'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove debug line
@@ -52,6 +53,10 @@ const usePageMenuOptionUI = () => { | |||
addClasses('bl-italic'), | |||
)(ComponentFormLink as ComponentType<StylableProps>); | |||
|
|||
const PageTreeLink = addClasses( | |||
'bl-cursor-pointer bl-text-xs bl-block hover:bl-underline hover:bl-text-yellow-500' | |||
)(A); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not ComponentFormLink
?
Changes
Test Instructions
Known Issues