Skip to content

Commit

Permalink
fix(bodiless/cli): update node version support to v18 (#2111)
Browse files Browse the repository at this point in the history
* fix(bodiless/cli): update node version support to v18

* fix(bodiless/cli, github action): update node version support to v18
  • Loading branch information
dewen committed Jun 1, 2023
1 parent 4eb992f commit c23379a
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-test-lint-simple.yml
Expand Up @@ -20,10 +20,10 @@ jobs:
ref: ${{ github.event.pull_request.head.sha }}
# install a specific version of Node using
# https://github.com/actions/setup-node
- name: Use Node.js v16.13
- name: Use Node.js v18.16
uses: actions/setup-node@v3
with:
node-version: 16.13
node-version: 18.16
cache: 'npm'
- name: Print Git Version
run: git --version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-canary-release.yml
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: '16.13'
node-version: '18.16'
- name: Build
run: npm run setup
- name: Publish Canary Release
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prerelease.yaml
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: '16.13'
node-version: '18.16'
- name: Setup git user
run: |
git config user.name "GitHub Actions Bot"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v2
with:
node-version: '16.13'
node-version: '18.16'
- name: Setup git user
run: |
git config user.name "GitHub Actions Bot"
Expand Down
4 changes: 2 additions & 2 deletions packages/bodiless-cli/src/helpers/AbstractNew.ts
Expand Up @@ -493,8 +493,8 @@ abstract class AbstractNew<O extends AbstractNewOptions> extends Wizard<O> {
// eslint-disable-next-line class-methods-use-this
async validate() {
const v = process.version;
if (!v.match(/^v16\./)) {
throw new Error(`Unsupported node version: ${v}. Must be v16.x`);
if (!v.match(/^v18\./)) {
throw new Error(`Unsupported node version: ${v}. Must be v18.x`);
}
}

Expand Down

5 comments on commit c23379a

@vercel
Copy link

@vercel vercel bot commented on c23379a Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

bodiless-js-examples – ./sites/vital-examples

bodiless-js-examples.vercel.app
bodiless-js-examples-git-main-jnj-demo-account.vercel.app
bodiless-js-examples-jnj-demo-account.vercel.app

@vercel
Copy link

@vercel vercel bot commented on c23379a Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on c23379a Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

bodiless-js-next – ./sites/vital-demo-next

bodiless-js-next-git-main-jnj-demo-account.vercel.app
bodiless-js-next.vercel.app
bodiless-js-next-jnj-demo-account.vercel.app

@vercel
Copy link

@vercel vercel bot commented on c23379a Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

bodiless-js-gatsby – ./sites/vital-demo

bodiless-js-gatsby-jnj-demo-account.vercel.app
bodiless-js-gatsby-git-main-jnj-demo-account.vercel.app
bodiless-js-gatsby.vercel.app

@vercel
Copy link

@vercel vercel bot commented on c23379a Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

bodiless-js – ./sites/vital-demo

bodiless-js-jnj-demo-account.vercel.app
bodiless-js.vercel.app
bodiless-js-git-main-jnj-demo-account.vercel.app

Please sign in to comment.