New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cx-templates, cx-flowcontainer): Add generic template #1483
Merged
hvanyo
merged 38 commits into
johnsonandjohnson:main
from
wodenx:feature/cx-generic-template
Apr 4, 2022
Merged
feat(cx-templates, cx-flowcontainer): Add generic template #1483
hvanyo
merged 38 commits into
johnsonandjohnson:main
from
wodenx:feature/cx-generic-template
Apr 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanyo
reviewed
Mar 23, 2022
hvanyo
reviewed
Mar 24, 2022
|
||
export default FlowContainerClean; | ||
|
||
// @todo add after static replacement merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wodenx can we do now, Static code is in this PR -- yes?
@@ -0,0 +1,39 @@ | |||
import { asFluidToken, asMetaToken } from '@bodiless/cx-elements'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh we should run script to add headers
wodenx
changed the title
WIP on generic template
feat(cx-templates, cx-flowcontainer): Add generic template and default flow container
Mar 25, 2022
wodenx
changed the title
feat(cx-templates, cx-flowcontainer): Add generic template and default flow container
feat(cx-templates, cx-flowcontainer): Add generic template
Mar 25, 2022
hvanyo
previously approved these changes
Mar 25, 2022
Fix/generic v5
Add tailwind to cx-flowcontainer
remove dup of generic template & header/footer
Fix/generic v7
hvanyo
previously approved these changes
Apr 4, 2022
TatsianaMiraniuk
previously approved these changes
Apr 4, 2022
comment out cypress
TatsianaMiraniuk
approved these changes
Apr 4, 2022
hvanyo
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add generic template and default flow container to cx design system
Related Issues
Closes #1463