Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cx-templates, cx-flowcontainer): Add generic template #1483

Merged
merged 38 commits into from Apr 4, 2022

Conversation

wodenx
Copy link
Contributor

@wodenx wodenx commented Mar 23, 2022

Changes

Add generic template and default flow container to cx design system

Related Issues

Closes #1463

@hvanyo hvanyo linked an issue Mar 23, 2022 that may be closed by this pull request
@hvanyo hvanyo marked this pull request as ready for review March 24, 2022 22:14

export default FlowContainerClean;

// @todo add after static replacement merges.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wodenx can we do now, Static code is in this PR -- yes?

@@ -0,0 +1,39 @@
import { asFluidToken, asMetaToken } from '@bodiless/cx-elements';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh we should run script to add headers

@wodenx wodenx changed the title WIP on generic template feat(cx-templates, cx-flowcontainer): Add generic template and default flow container Mar 25, 2022
@wodenx wodenx changed the title feat(cx-templates, cx-flowcontainer): Add generic template and default flow container feat(cx-templates, cx-flowcontainer): Add generic template Mar 25, 2022
@cypress
Copy link

cypress bot commented Mar 25, 2022



Test summary

42 22 0 0Flakiness 0


Run details

Project bodiless
Status Failed
Commit fad319b ℹ️
Started Apr 4, 2022 7:15 PM
Ended Apr 4, 2022 7:33 PM
Duration 18:23 💡
OS Linux Ubuntu - 20.04
Browser Chrome 100

View run in Cypress Dashboard ➡️


Failures

cypress/integration/smokeTest/cards_spec.js 10 Failed
1 Card testing > cards: 1 - filling in Title
2 Card testing > cards: 2 - filling in Body
3 Card testing > cards: 3 - filling in CTA text
4 Card testing > cards: 7 - checking data in Preview Mode
5 Card testing > cards: 8 - checking that the data still present in Edit Mode after switching back from Preview Mode
6 Card testing > cards: 9 - editing Title
7 Card testing > cards: 10 - editing Description
8 Card testing > cards: 11 - editing CTA label
9 Card testing > cards: 14 - checking edited data in Preview Mode
10 Card testing > cards: 15 - checking the edited data still present in Edit Mode
This comment includes only the first 10 test failures. See all 22 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

hvanyo
hvanyo previously approved these changes Mar 25, 2022
@TatsianaMiraniuk TatsianaMiraniuk self-requested a review April 1, 2022 22:01
hvanyo
hvanyo previously approved these changes Apr 4, 2022
@wodenx wodenx dismissed stale reviews from TatsianaMiraniuk and hvanyo via 0e598b7 April 4, 2022 21:07
@TatsianaMiraniuk TatsianaMiraniuk self-requested a review April 4, 2022 21:17
@hvanyo hvanyo merged commit d1c1e46 into johnsonandjohnson:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants