feat(gatsby-theme-bodiless, backend, hydration, layouts, tokens, ga4): Replace crypto-browserify with crypto-js #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wodenx
previously approved these changes
Sep 12, 2022
marcopagliarulo
force-pushed
the
feature/replace-crypto-with-crypto-js
branch
from
4c154bd
to
0cac0ec
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marcopagliarulo
changed the title
marcopagliarulo
force-pushed
the
feature/replace-crypto-with-crypto-js
branch
from
0cac0ec
to
df34636
Compare
marcopagliarulo
force-pushed
the
feature/replace-crypto-with-crypto-js
branch
from
df34636
to
ba78186
Compare
|
Someone is attempting to deploy a commit to the JNJ Demo Account Team on Vercel. A member of the Team first needs to authorize it. |
wodenx
previously approved these changes
Apr 4, 2023
marcopagliarulo
changed the title
VancheeZze
previously approved these changes
Apr 5, 2023
VancheeZze
previously approved these changes
Apr 5, 2023
wodenx
reviewed
Apr 5, 2023
| @@ -64,6 +64,7 @@ jobs: | |||
| env: | |||
| APPLITOOLS_API_KEY: ${{ secrets.APPLITOOLS_API_KEY }} | |||
| run: | | |||
| export APPLITOOLS_BATCH_NAME="${{ github.event.pull_request.title }} (${{ github.event.pull_request.number }})" | |||
There was a problem hiding this comment.
@marcopagliarulo what's this about>
| @@ -0,0 +1,63 @@ | |||
| /** | |||
There was a problem hiding this comment.
Because fileHelper.js uses MD5, I wrote a test for it which was not covered by any test
added 2 commits
April 5, 2023 18:19
…: Replace crypto-browserify with crypto-js [Canary]
marcopagliarulo
force-pushed
the
feature/replace-crypto-with-crypto-js
branch
from
d224834
to
e8d8dd8
Compare
wodenx
approved these changes
Apr 5, 2023
VancheeZze
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Crypto-browserify is not under active maintenance (last release 5 years ago). It bring outdated dependencies and multiple version of the same package inside the client bundle.
Replace crypto-browserify with crypto-js,
Test Instructions
File upload
PLP GA4
withoutHydration
flowContainer Item creation
Move files to public
DefaultContent
Tokens
Related Issues
Fixes #1954