Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-theme-bodiless, lerna): patch Lerna canary version generation [canary] #2037

Merged

Conversation

marcopagliarulo
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Thank you for creating a pull request on GitHub! We appreciate your contribution to our repository.

In order to enable our tests to run on your changes, we kindly ask that you wait until one of our repository members adds the ready-to-test label to your pull request. (Please request on the GitHub issue you are addressing.) This will ensure that our testing process runs smoothly and we can quickly verify the changes you've made.

Thank you for your understanding and we look forward to reviewing your changes soon!

@marcopagliarulo marcopagliarulo changed the title fix(gatsby-theme-bodiless, lerna): patch Lerna canary version generation fix(gatsby-theme-bodiless, lerna): patch Lerna canary version generation [canary] Apr 18, 2023
VancheeZze
VancheeZze previously approved these changes Apr 18, 2023
@vercel
Copy link

vercel bot commented Apr 18, 2023

Someone is attempting to deploy a commit to the JNJ Demo Account Team on Vercel.

A member of the Team first needs to authorize it.

@@ -86,7 +86,7 @@
"gatsby-plugin-postcss": "5.10.0",
"gatsby-plugin-react-helmet": "^5.10.0",
"gatsby-plugin-remove-serviceworker": "^1.0.0",
"gatsby-plugin-robots-txt": "^1.7.0",
"gatsby-plugin-robots-txt": "1.7.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcopagliarulo why do we want to fix the version to 1.7.1 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because version 1.8 requires Gatsby 5

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bodiless-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 3:35pm

dewen
dewen previously approved these changes Apr 18, 2023
@github-actions
Copy link

Playwright Test Results

196 tests   181 ✔️  51m 59s ⏱️
  14 suites    15 💤
    2 files        0

Results for commit f65d086.

@marcopagliarulo marcopagliarulo merged commit cf67a5d into johnsonandjohnson:main Apr 18, 2023
7 checks passed
@marcopagliarulo marcopagliarulo deleted the fix/lerna-canary branch April 18, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants