fix(filtering, page, next): editing bugs on NextJS #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@marcopagliarulo is attempting to deploy a commit to the JNJ Demo Account Team on Vercel. A member of the Team first needs to authorize it. |
marcopagliarulo
changed the title
wodenx
reviewed
May 24, 2023
| return fs | ||
| .readdirSync(dir) | ||
| .filter((file) => fs.statSync(`${dir}/${file}`).isDirectory()); | ||
| } catch (error) { |
There was a problem hiding this comment.
What error are we ignoring here?
There was a problem hiding this comment.
Here we check for subdirs, if there is any error, returns an empty array.
wodenx
previously approved these changes
May 24, 2023
dewen
approved these changes
May 24, 2023
hvanyo
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test Instructions
Related Issues