Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important typo in FinishedPlyaing in README #55

Closed
LucaLovagnini opened this issue May 26, 2019 · 1 comment
Closed

Important typo in FinishedPlyaing in README #55

LucaLovagnini opened this issue May 26, 2019 · 1 comment

Comments

@LucaLovagnini
Copy link

In README file, under addEventListener section there's an error:

_onFinishedPlayingSubscription = SoundPlayer.addEventListener('**FinishedPlyaing**', ({ success }) => {

Instead of:

_onFinishedPlayingSubscription = SoundPlayer.addEventListener('**FinishedPlaying**', ({ success }) => {

This caused a bug from my quick copy/paste =)
@johnsonsu
Copy link
Owner

Nice catch! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnsonsu @LucaLovagnini