Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some notification cleanups and suppressions of unwanted errors #62

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I have one more PR after this one (like the previous ones I will soak this for a few days) and then we should be ready for the 1.6.0 release. 🙂

@johnthagen
Copy link
Owner

then we should be ready for the 1.6.0 release

Sounds good. When you're ready for a new release, make a new issue and assign it to me. I'll test out and the do the release.

@firewave
Copy link
Collaborator Author

Sounds good. When you're ready for a new release, make a new issue and assign it to me. I'll test out and the do the release.

I would have just created a PR with the release preparation and version bump in separate commit you could have merged and set the tag on the first one. Can file a ticket as well.

But there might yet be another PR before that - I found another TODO I want to look at first ...

@johnthagen
Copy link
Owner

Yes, if you want to do a PR, that also sounds good.

@johnthagen
Copy link
Owner

@firewave Now that you are a full maintainer, I added a Maintainers section to the README with you included. I think this could make the changelog nicer if we didn't add (Contribution by @firewave) to each line. I want you to get credit for your great work, but maybe this way the changelog is a little cleaner? What do you think?

@firewave
Copy link
Collaborator Author

Now that you are a full maintainer, I added a Maintainers section to the README with you included. I think this could make the changelog nicer if we didn't add (Contribution by @firewave) to each line. I want you to get credit for your great work, but maybe this way the changelog is a little cleaner? What do you think?

Thanks. That makes sense. I will cleanup the logs when I prepare the release.

… - will be properly handled in an upcoming change / suppress "unmatchedSuppression" and "purgedConfiguration" finding
@firewave firewave merged commit 3ca3e74 into johnthagen:master Jan 7, 2021
@firewave firewave deleted the stuff branch January 7, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants