-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Failed to load url - has no information #193
Comments
Sounds feasible maybe. You would need to make sure you don't mix up the I doubt I will have time to do it myself any time soon. Any thoughts @johntitus? |
I also have this problem, please push solution! |
What problem do you have @nevmerzhitsky? This issue is a feature request, not a bug report. |
@nevmerzhitsky and @flashhhh, can you try setting the horseman timeout to something big, like 30 seconds, and retrying this? |
Hi, @johntitus! Will try this a bit later. Is upgrading the package to the latest version required? Our current working version is |
If you don't set the timeout in the Horseman constructor, it defaults to just 5 seconds. It looks like that if a timeout occurs, the first thing that happens is the resource requested fails, which is the error that shows up, instead of a timeout. I do recommend upgrading before testing, just to ensure we're all on the same page. |
Rechecked. As I said, we already set a large timeout value (30 sec currently). I tested with greater values (like 60) and nothing changed. |
Still persists for me even when settings timeout to 30 seconds. Has to be something with loading the page, it error's within the first couple seconds of it trying to load a page for me over https with the 30 second timeout. So the large timeout is more-so redundant than anything with this bug. |
My original problem description is here.
What I found is that it's possible to detect the exact error using the
onResourceError
callback which gets fired before theonLoadFinished
. So we can remember the last error and show it ifonLoadFinished
returnsfail
status.I didn't do it myself because I feel that using such callbacks in the core might violate some rules or good practices of the project. Please, let me know what you think about the idea, so I can make a PR or just do it yourself if you feel like it.
The text was updated successfully, but these errors were encountered: