Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onChangeEnd handler #579

Closed
wants to merge 3 commits into from

Conversation

bryanjclark
Copy link

Hi! I was running into an issue with allotment where its onChange handler's constant-firing was creating some performance issues in a webapp that I'm working on.

I'd like to propose adding an onChangeEnd callback, which gets called exactly-once when the user either (a) stops-dragging-with-their-mouse or (b) clicks Reset for the layout.

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for allotment-storybook ready!

Name Link
🔨 Latest commit 4e9403c
🔍 Latest deploy log https://app.netlify.com/sites/allotment-storybook/deploys/641cbc00a93e1d000856109a
😎 Deploy Preview https://deploy-preview-579--allotment-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for allotment-website canceled.

Name Link
🔨 Latest commit 4e9403c
🔍 Latest deploy log https://app.netlify.com/sites/allotment-website/deploys/641cbc006521f200081394d2

@masesk
Copy link
Contributor

masesk commented Apr 4, 2023

Check this:
#576

@bryanjclark
Copy link
Author

Looks like my PR is no longer needed - closing!

@bryanjclark bryanjclark deleted the add-on-drag-end branch April 25, 2023 22:48
@johnwalley
Copy link
Owner

Hi @bryanjclark. Do let me know if there is anything missing in the merged PR that isn't in yours. I really appreciate you taking the time to put together a PR and it's just the fact that I'm merging things in the order they arrived 👍.

@bryanjclark
Copy link
Author

Oh it's all good! I'm just excited to have the functionality - was getting some weird lagginess in our frontend from the constant-calling-of-the-callback-function (even with debounce somehow?) so I'm glad there's now an option to just get an update once the drag is complete. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants