Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Verbosity #256

Open
kmaurinjones opened this issue May 1, 2023 · 1 comment · May be fixed by #185
Open

Reduce Verbosity #256

kmaurinjones opened this issue May 1, 2023 · 1 comment · May be fixed by #185

Comments

@kmaurinjones
Copy link

Is your feature request related to a problem? Please describe.
Love the library! It's been very useful for a lyric analysis project I'm working on, but since I'm getting lyrics for all artists at a time (some of which have hundreds of songs), I'm getting enormous and verbose printouts that can exceed 1000 lines of text.

Describe the solution you'd like
It would be amazing if there could be a "verbose = False" argument (or something equivalent) added to each retrieval method (I'm currently using .search_song(), to avoid this.

Describe alternatives you've considered
While the most ideal solution is what I've put above (this way I can write my own progress-printing statement, or have nothing at all if I want), I would settle for a simple printed statement that lists the numerical id of a song in relation to the total number being retrieved, that simply is re-written over the same line. Something like: print(f"Song {song_num_id} of {len(all_songs)}", end = '\r')

@allerter
Copy link
Collaborator

That's certainly a good idea, but we'll probably introduce the logging module to the library and remove the verbose argument altogether (#185). That way we will have total control over the output.

@allerter allerter linked a pull request May 27, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants