Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_artist should use Genius's the list songs endpoint from the artist's page #68

Closed
johnwmillr opened this issue Nov 25, 2018 · 1 comment
Assignees

Comments

@johnwmillr
Copy link
Owner

Is your feature request related to a problem? Please describe.
The current Genius.search_artist method relies on a heuristic for finding song's by the requested artist. This method is slow, inefficient, and may miss songs that belong to the artist.

Describe the solution you'd like
Use the same endpoint Genius.com uses when listing songs on an artist's page.

Here is an example of the all songs endpoint for Jay-Z:

Additional context
Not sure if this API endpoint is publicly listed by Genius, but the endpoint returns a 200 when I make a request to it.

@johnwmillr johnwmillr self-assigned this Nov 25, 2018
@johnwmillr
Copy link
Owner Author

Oh, I'm already doing this and the endpoint is supported by Genius.

Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant