Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import via SPM #268

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

larryonoff
Copy link
Contributor

This's strange but I'm trying to replicate the error that I and, but not able yet :)

@larryonoff
Copy link
Contributor Author

@johnxnguyen could you please check this PR and if it's fine make new release?

@johnxnguyen
Copy link
Owner

@larryonoff my apologies for the delayed responses, I've been a bit of sick leave recently and back to a busy work schedule so time has been scarce.

I'm not sure I fully understand the problem this PR is solving, could you give some more context please?

Also, travis has been acting up lately and not running tests so I need to fix that first. I'm considering switching to another CI provider.

@larryonoff
Copy link
Contributor Author

@johnxnguyen our team develops internal framework. Some of the packages use external dependencies like Down. The structure of our main app is: App imports InternalSDK.PackageX, InternalSDK.PackageX imports Down.

We started migration to SPM from Cococapods recently. But we had an error with Down: Missing required module 'libcmark'. No such module 'libcmark'.

This PR should fix it.

PS. Strange thing that I cannot reproduce the issue now using the tag 0.11.

@larryonoff
Copy link
Contributor Author

Cleaned the project, updated all dependencies. As result "Missing required module 'libcmark'" for the current tag 0.11

@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #268 (9dd46e0) into master (3b07bb5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   91.15%   91.15%           
=======================================
  Files          60       60           
  Lines        1063     1063           
=======================================
  Hits          969      969           
  Misses         94       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b07bb5...9dd46e0. Read the comment docs.

verstaen added a commit to verstaen/Down that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants