Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the project settings to use the Legacy Build System. #97

Merged
merged 1 commit into from Aug 13, 2018
Merged

Updates the project settings to use the Legacy Build System. #97

merged 1 commit into from Aug 13, 2018

Conversation

pieromattos
Copy link
Contributor

This fixes #91 by changing the project's build settings to use the Legacy Build System.

This should avoid crashes under Xcode 10 Betas for now.

Credit/Thanks to @MrAlek for pointing out the fix. 馃憤

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.923% when pulling 534a0f3 on pieromattos:build-fix into 713f570 on iwasrobbed:master.

iwasrobbed
iwasrobbed approved these changes Aug 13, 2018
View reviewed changes
Copy link
Collaborator

@iwasrobbed iwasrobbed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 馃憤

@iwasrobbed iwasrobbed merged commit 1c3c8db into johnxnguyen:master Aug 13, 2018
@torokzsolt torokzsolt mentioned this pull request Sep 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwasrobbed iwasrobbed iwasrobbed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Xcode 10] Crash in XCBuildService; need to use old build system
3 participants
@pieromattos @coveralls @iwasrobbed