Add BinInt, implement divmod and just for fun, add Nat.scala #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 91.32% 91.70% +0.38%
==========================================
Files 96 97 +1
Lines 11846 12160 +314
Branches 2675 2818 +143
==========================================
+ Hits 10818 11151 +333
+ Misses 1028 1009 -19 ☔ View full report in Codecov by Sentry. |
johnynek
commented
Apr 10, 2024
test_workspace/BinInt.bosatsu
Outdated
| match b: | ||
| case BWNot(b): | ||
| # -a - 1 <> -b - 1 == (a <> b).invert | ||
| match cmp_BinNat(a, b): |
There was a problem hiding this comment.
this could just be cmp_BinNat(b, a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.