Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable substitution in dotenv files #47

Merged
merged 4 commits into from
Jan 15, 2018

Conversation

sachaos
Copy link

@sachaos sachaos commented Nov 20, 2017

One of #38 .

@joho
Copy link
Owner

joho commented Nov 25, 2017

Thanks so much for this patch. Apologies for the delay reviewing, my first child was born last and I was off the computer until now. I'll merge, let it settle in on master for a while, and then cut a release in the upcoming weeks.

@sachaos
Copy link
Author

sachaos commented Nov 25, 2017

@joho Oh, Congratulations!
Thank you for reply.

@sp-emili-calonge
Copy link

Any update on this? It'd be very helpful for me if this was merged. Thanks for your work!

@joho
Copy link
Owner

joho commented Jan 15, 2018

Oh crap, this was totally a brain fart, I thought I had merged this and it was just plugging away on master. Sorry. Merging now.

@joho joho merged commit 6bb0851 into joho:master Jan 15, 2018
@sachaos
Copy link
Author

sachaos commented Jan 15, 2018

Thank you! 🎉

@sp-emili-calonge
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants