Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

functionality for listening to assertions #51

Closed
johrstrom opened this issue Mar 16, 2019 · 1 comment
Closed

functionality for listening to assertions #51

johrstrom opened this issue Mar 16, 2019 · 1 comment
Assignees
@johrstrom

Comments

@johrstrom
Copy link
Owner

Currently we can only listen to samples. This ticket is to provide that functionality like this

  • if label is specified, the collect results for all the assertions (if there are more than 1)
  • if label is not specified simply collect from the last.
  • only counter type and success ratio metrics should be able to listen to assertions.

I'm not sure if it makes sense to measure assertions with complex types like Histograms and Summaries measuring things like response size (example: A histogram of assertion response sizes?), but I'm welcome to community feedback.
@johrstrom johrstrom self-assigned this Mar 17, 2019
johrstrom added a commit that referenced this issue Mar 17, 2019
@johrstrom
#51 functionality for assertions
fddfd2c
@johrstrom
Copy link
Owner Author

This is complete in the 0.4.0 release, but if label is not specified then it will count increment for all assertions, not just the last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johrstrom johrstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johrstrom