Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for tag install issue #502

Merged
merged 2 commits into from Jun 26, 2023
Merged

Conversation

bueche
Copy link
Contributor

@bueche bueche commented Jun 26, 2023

Description

the npm install command did not like the package.json syntax for supporting 15 and 16 versions of graphql. this didn't show up in all of the tests until I did a manual install of the pushed join-monster v 3.3.0. this patches the problem by only supporting version 16.

The error looks as follows:

c889f3bd2e05 test-proj % npm install join-monster      
npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name "^16.0.0|^15.4.0" of package "graphql@^16.0.0|^15.4.0": Tags may not have any characters that encodeURIComponent encodes.

  • [x ] This change adds test coverage for new/changed/fixed functionality

Checklist

  • [x ] I have added documentation for new/changed functionality in this PR via comments and by updating the change log

@bueche bueche merged commit 9340b4c into join-monster:master Jun 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant