Add aliasPrefix option
#533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoabie
reviewed
May 17, 2024
jasonwoodland
force-pushed
the
fix/issue-532
branch
from
2a75cde
to
a7e7170
Compare
Co-authored-by: Nico Gallinal <nicoabie@gmail.com>
Co-authored-by: Nico Gallinal <nicoabie@gmail.com>
|
@jasonwoodland there is an alias-namespace test file, please make sure to add a test there as well. |
nicoabie
approved these changes
May 17, 2024
nicoabie
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
prefixAliasesproperty to the join-monster options object. When set to true, table and column aliases are prefixed with "$" to avoid conflicting with commonly used single-letter aliases defined in where/join subqueries.References
$or similar #532Testing
No change when prefixAliases is omitted. When specified, generated SQL queries contain the prefixed string.
Checklist