Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DApp to use new Charter schema #501

Closed
am9u opened this issue Oct 8, 2018 · 0 comments
Closed

Update DApp to use new Charter schema #501

am9u opened this issue Oct 8, 2018 · 0 comments
Assignees
@tobek
Labels
dapp relates to DApp front-end
Projects
Governance Launch

Comments

@am9u
Copy link
Contributor

am9u commented Oct 8, 2018

In PR #484, two breaking changes were made regarding Newsroom Charters:

  • the schema for Newsroom Charters was changed
  • an update was made to @joincivil/core to parse the charter content from IPFS into a JS object directly in core. previously, this field was a string and the DApp was parsing that string into an object.

PR #500 was merged as a temporary fix for rendering legacy charter data, but the DApp needs to be updated to use the new Charter schema
@am9u am9u added the dapp relates to DApp front-end label Oct 8, 2018
@nickreynolds nickreynolds added this to In progress in Governance Launch Oct 22, 2018
@tobek tobek moved this from In progress to Needs review in Governance Launch Nov 26, 2018
tobek added a commit that referenced this issue Nov 26, 2018
@tobek
Handle new charter schema [#501]
b122482
tobek added a commit that referenced this issue Nov 28, 2018
@tobek
Merge pull request #628 from joincivil/tobek/dapp/charter
4ca527e 
Handle new charter schema + style output on listing page [#501] [#603]
@tobek tobek moved this from Needs review to Done in Governance Launch Nov 28, 2018
@tobek tobek closed this as completed Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobek tobek

Labels
dapp relates to DApp front-end
Projects
No open projects
Governance Launch
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@am9u @tobek