DApp: User can Propose Reparameterization #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 14, 2018 19:31
- Add API wrapper methods for performing reparam proposal - Add React elements for capturing the proposal and render the view on the Parameterizer page
…pose-reparameterization
- Add `approveForProposeReparameterization` API wrapper method - Wire up proposal transaction button to approve, then propose
|
|
||
| export async function proposeReparameterization( | ||
| paramName: string, | ||
| newValue: BigNumber, |
There was a problem hiding this comment.
have you tested this when running the built & served version of the DApp?
There was a problem hiding this comment.
Good catch! I tested locally with the dev build. The transactions all go through, but I'll try this with the built+served version before I move forward.
Pull Request Test Coverage Report for Build 3255
💛 - Coveralls |
walfly
approved these changes
May 16, 2018
| @@ -50,6 +50,18 @@ export async function approve(amount: BigNumber): Promise<TwoStepEthTransaction | |||
| } | |||
| } | |||
|
|
|||
| export async function approveForProposeReparameterization(): Promise<TwoStepEthTransaction | void> { | |||
| const civil = getCivil(); | |||
| const tcr = civil.tcrSingletonTrusted(); | |||
walfly
reviewed
May 16, 2018
| } | ||
|
|
||
| export default Parameterizer; | ||
| const mapToStateToProps = (state: State, ownProps: ParameterizerPageProps): object => { |
There was a problem hiding this comment.
not using ownprops, return type should be specified
| import { setParameter } from "../actionCreators/parameterizer"; | ||
| import { getParameterValue } from "../apis/civilTCR"; | ||
|
|
||
| export async function initializeParameterizer(dispatch: Dispatch): Promise<void> { |
There was a problem hiding this comment.
how are we keeping the parameter page in sync? is there an event we can subscribe to
…pose-reparameterization
…terValues` update - Add `MULTI_SET_PARAMETERS` action and reducer to squash the state changes into a single update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also moves the Parameterizer State into Redux