adding sub-tabs for listings in progress #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to can challenge be resolved removing logs running prettier
nickreynolds
force-pushed
the
nickreynolds/listing-sub-tabs
branch
from
f25d3b5
to
e053451
Compare
Pull Request Test Coverage Report for Build 3290
💛 - Coveralls |
am9u
approved these changes
May 21, 2018
| @@ -63,5 +63,5 @@ export function canResolveChallenge(challengeData: ChallengeData): boolean { | |||
| * @param challengeData this ChallengeData to check | |||
| */ | |||
| export function doesChallengeHaveAppeal(challengeData: ChallengeData): boolean { | |||
| return !challengeData.appeal || is0x0Address(challengeData!.appeal!.requester.toString()); | |||
| return challengeData.appeal! && !is0x0Address(challengeData!.appeal!.requester.toString()); | |||
There was a problem hiding this comment.
Durrrr. Thanks for fixing this.
walfly
reviewed
May 21, 2018
|
|
||
| class ListingsInProgress extends React.Component<ListingProps> { | ||
| public render(): JSX.Element { | ||
| const applications = this.props.applications; |
There was a problem hiding this comment.
should these be represented in the reducers? Like instead of merging them here, get rid of the smaller categories and replace them with meaningful sets?
There was a problem hiding this comment.
I'd rather keep the small categories at least for now. Don't think we're even sure what exactly the bigger categories would be, this makes it a bit easier to change things around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also: