add bare bones coral talk commenting #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4980
💛 - Coveralls |
nickreynolds
approved these changes
Jul 5, 2018
walfly
reviewed
Jul 5, 2018
| } | ||
|
|
||
| public async componentDidMount(): Promise<void> { | ||
| const discourseUrl = process.env.REACT_APP_DISCOURSE_URL; |
There was a problem hiding this comment.
I followed the usage specified here
There was a problem hiding this comment.
neet. I didn't know create react app could do that
walfly
approved these changes
Jul 5, 2018
walfly
reviewed
Jul 5, 2018
| import { ViewModule } from "../utility/ViewModules"; | ||
|
|
||
| class ListingDiscourse extends React.Component { | ||
| constructor(props: {}) { |
walfly
reviewed
Jul 5, 2018
| tag.async = true; | ||
| tag.src = discourseUrl + "/static/embed.js"; | ||
|
|
||
| const handleCallback = () => { |
There was a problem hiding this comment.
how does this get cleaned up, how does it load correct discussion
There was a problem hiding this comment.
It loads it in an iframe and creates a discussion per URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.