Fix RTL attribute usage.

joindin · Jul 27, 2015 · e4e3256 · e4e3256
1 parent 5624d9e
commit e4e3256
Show file tree

Hide file tree

Showing 7 changed files with 34 additions and 26 deletions.
diff --git a/source/AndroidManifest.xml b/source/AndroidManifest.xml
@@ -27,6 +27,7 @@
         android:allowBackup="true"
         android:icon="@drawable/ic_launcher"
         android:label="@string/app_name"
+        android:supportsRtl="true"
         android:theme="@style/JoindInActionBarTheme">
 
         <!-- Just a bunch of activities here. Needed otherwise android cannot launch them. -->

diff --git a/source/res/layout/activity_settings.xml b/source/res/layout/activity_settings.xml
@@ -21,8 +21,9 @@
             android:id="@+id/gravatarImage"
             android:layout_width="50dp"
             android:layout_height="50dp"
-            android:layout_gravity="center_vertical|left"
+            android:layout_gravity="center_vertical|start"
             android:layout_marginRight="@dimen/activity_horizontal_margin"
+            android:layout_marginEnd="@dimen/activity_horizontal_margin"
             android:visibility="gone" />
 
         <TextView
@@ -37,7 +38,7 @@
         <Button
             android:id="@+id/logInOutButton"
             android:text="@string/prefAuthLogInButton"
-            android:layout_gravity="center_vertical|right"
+            android:layout_gravity="center_vertical|end"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content" />
 

diff --git a/source/res/layout/addcomment.xml b/source/res/layout/addcomment.xml
@@ -13,7 +13,7 @@
             android:layout_height="wrap_content"
             android:text="@string/your_rating"
             android:layout_width="match_parent"
-            android:id="@+id/TextViewRating"></TextView>
+            android:id="@+id/TextViewRating" />
         <RatingBar
             android:id="@+id/CommentRatingBar"
             android:layout_width="wrap_content"
@@ -22,14 +22,13 @@
             android:rating="0"
             android:stepSize="1"
             style="@style/joindinRatingBar"
-            android:layout_margin="5dp"
-            ></RatingBar>
+            android:layout_margin="5dp" />
     </LinearLayout>
     <TextView
         android:id="@+id/TextView01"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Your comment:"></TextView>
+        android:text="Your comment:" />
 
     <TableRow
         android:id="@+id/TableRow01"
@@ -44,10 +43,10 @@
             android:maxLength="1024"
             android:gravity="top"
             android:layout_width="wrap_content"
-            android:layout_gravity="right"
+            android:layout_gravity="end"
             android:layout_weight="1"
             android:maxLines="4"
-            android:minLines="4"></EditText>
+            android:minLines="4" />
     </TableRow>
 
     <CheckBox
@@ -68,15 +67,15 @@
             android:layout_gravity="center_horizontal"
             android:layout_width="wrap_content"
             android:id="@+id/ButtonAddCommentSend"
-            android:layout_weight="1"></Button>
+            android:layout_weight="1" />
 
         <Button
             android:layout_height="wrap_content"
             android:text="Cancel"
             android:layout_gravity="center_horizontal"
             android:layout_width="wrap_content"
             android:id="@+id/ButtonAddCommentCancel"
-            android:layout_weight="1"></Button>
+            android:layout_weight="1" />
     </LinearLayout>
 
 </LinearLayout>
diff --git a/source/res/layout/eventrow.xml b/source/res/layout/eventrow.xml
@@ -9,6 +9,7 @@
         android:layout_height="50dip"
         android:layout_width="50dip"
         android:visibility="gone"
+        android:layout_marginEnd="10dp"
         android:layout_marginRight="10dp" />
 
     <LinearLayout
@@ -26,7 +27,7 @@
             android:ellipsize="end"
             android:singleLine="true"
             android:id="@+id/EventDetailCaption"
-            android:textSize="16dip"/>
+            android:textSize="16sp"/>
 
         <TableLayout
             android:id="@+id/TableLayout01"
@@ -44,7 +45,7 @@
                     android:layout_height="wrap_content"
                     android:id="@+id/EventDetailAttendingImg"
                     android:background="@drawable/rating_full_orange"
-                    android:layout_margin="2px" />
+                    android:layout_margin="2dp" />
 
                 <TextView
                     android:layout_width="match_parent"

diff --git a/source/res/layout/pull_to_refresh_header.xml b/source/res/layout/pull_to_refresh_header.xml
@@ -22,13 +22,15 @@
     android:gravity="center"
         android:id="@+id/pull_to_refresh_header"
     >
-    <ProgressBar 
+    <ProgressBar
         android:id="@+id/pull_to_refresh_progress"
         android:indeterminate="true"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginLeft="30dip"
+        android:layout_marginStart="30dip"
         android:layout_marginRight="20dip"
+        android:layout_marginEnd="20dip"
         android:layout_marginTop="10dip"
         android:visibility="gone"
         android:layout_centerVertical="true"
@@ -39,7 +41,9 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginLeft="30dip"
+        android:layout_marginStart="30dip"
         android:layout_marginRight="20dip"
+        android:layout_marginEnd="20dip"
         android:visibility="gone"
         android:layout_gravity="center"
         android:gravity="center"

diff --git a/source/res/layout/talkrow.xml b/source/res/layout/talkrow.xml
@@ -42,6 +42,7 @@
 
             <TextView
                 android:drawableLeft="@drawable/talk"
+                android:drawableStart="@drawable/talk"
                 android:layout_height="wrap_content"
                 android:textStyle="bold"
                 android:id="@+id/TalkRowCaption"
@@ -82,16 +83,17 @@
             android:background="@drawable/rating_0"
             android:layout_height="15dip"
             android:layout_width="75dip"
-            android:layout_marginTop="5px"
-            android:layout_marginRight="5px"
+            android:layout_marginTop="5dp"
+            android:layout_marginRight="5dp"
+            android:layout_marginEnd="5dp"
             android:id="@+id/TalkRowRating" />
 
         <TextView
-            android:layout_width="wrap_content"
+            android:layout_width="0dp"
             android:layout_height="wrap_content"
             android:id="@+id/TalkRowComments"
-            android:gravity="right"
-            android:layout_gravity="right"
+            android:gravity="end"
+            android:layout_gravity="end"
             android:text=""
             android:layout_weight="0.5" />
     </LinearLayout>
@@ -111,11 +113,11 @@
             android:text="" />
 
         <TextView
-            android:layout_width="wrap_content"
+            android:layout_width="0dp"
             android:layout_height="wrap_content"
-            android:layout_gravity="right"
+            android:layout_gravity="end"
             android:id="@+id/TalkRowTime"
-            android:gravity="right"
+            android:gravity="end"
             android:layout_weight="3"
             android:text="" />
     </LinearLayout>

diff --git a/source/res/layout/trackrow.xml b/source/res/layout/trackrow.xml
@@ -10,22 +10,22 @@
         android:layout_height="wrap_content"
         android:textStyle="bold"
         android:id="@+id/TrackRowCaption"
-        android:textSize="18dip"
+        android:textSize="18sp"
         android:ellipsize="end"
         android:singleLine="true"
         android:layout_width="match_parent"
-        android:text=""></TextView>
+        android:text="" />
 
     <TextView
         android:layout_width="wrap_content"
         android:id="@+id/TrackRowDescription"
         android:layout_height="match_parent"
-        android:text=""></TextView>
+        android:text="" />
 
     <TextView
         android:layout_height="wrap_content"
         android:id="@+id/TrackRowTalkCount"
         android:layout_width="match_parent"
-        android:gravity="right"
-        android:text=""></TextView>
+        android:gravity="end"
+        android:text="" />
 </LinearLayout>