Enhancement: Switch to using GitHub actions - #714
Conversation
|
Ha! https://github.com/joindin/joindin-api/pull/714/checks?check_run_id=261434086#step:3:9
|
| uses: actions/checkout@master | ||
|
|
||
| - name: "Install dependencies with composer" | ||
| run: $(which composer) install |
There was a problem hiding this comment.
@localheinz would you try throwing a --ignore-platform-reqs here to see if this gets us past this issue of misisng ext/intl?
There was a problem hiding this comment.
Not sure about that, to be honest.
Let's see what we need ext/intl for!
There was a problem hiding this comment.
Running
$ composer remove ext-intl
followed by
$ composer require-checker
in #727 yields
> composer-require-checker --config-file=composer-require-checker.json
ComposerRequireChecker 2.1.20-250-g14887fc-dev
The following unknown symbols were found:
+----------------+--------------------+
| unknown symbol | guessed dependency |
+----------------+--------------------+
| Transliterator | ext-intl |
+----------------+--------------------+
Script composer-require-checker --config-file=composer-require-checker.json handling the require-checker event returned with error code 1
so we actually need ext/intl.
Personally, I'd prefer not to run composer with the --ignore-platform-reqs options in CI.
Perhaps we can bug @nat with updating the images?
There was a problem hiding this comment.
038f8ef to
1bb5e25
Compare
|
Got the extensions installed, but still failing that it can't find the exention. |
229e860 to
06d0ce1
Compare
2f6eaf2 to
93a8311
Compare
| run: curl -s https://codecov.io/bash -o codecov | ||
|
|
||
| - name: "Send code coverage report to Codecov.io" | ||
| run: bash codecov -t ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
The CODECOV_TOKEN, taken from https://codecov.io/gh/joindin/joindin-api/settings, needs to be provided as a secret in the repository settings (see https://help.github.com/en/github/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets#creating-encrypted-secrets).
Unfortunately, this has the limitation that the secrets aren't available for pull request builds (unless the author has write access).
There was a problem hiding this comment.
CODECOV_TOKEN has been added
33f083f to
71beade
Compare
|
Other than #784, is there anything holding up merging this? |
Been thinking back and forth on handling code style. As stated in the issue I'm in favor of Style-CI because it takes the burden off me-the-contributor-making-the-pr, and off me-the-code-reviewer reviewing the PR, and off the entire organization as something we can set and forget. The Leadership Team had a discussion about this when Style-CI was proposed and the conclusion was to use Style-CI but not remove the tooling to run similar/hopefully the same style changes locally. I also wouldn't want a code style issue to fail a CI/CD build. Yes the project has adopted a code style but it shouldn't be a sticking point to accept a PR and it shouldn't be a code review item because it's too silly not to automate. Especially when tooling makes it so easy. I think what I'd prefer is to remove the Github action for "Coding Standards" and continue to allow Style-CI to automatically resolve CS issues. |
|
Been meaning to take a look to see whether we can match StyleCI to PSR-12...and maybe not enforce any other opinions. Just haven't gotten around to it, but once that config is available it should be useful for other projects. |
36fb38b to
06e81c5
Compare
|
This should be good to go then. The requirement for Travis CI needs to be removed from https://github.com/joindin/joindin-api/settings/branches for |
svpernova09
left a comment
svpernova09
left a comment
There was a problem hiding this comment.
Thanks for all of the work here.
|
Thank you, @svpernova09! |
3 participants
This PR