Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit comments #904

Open
endorama opened this issue Oct 21, 2020 · 2 comments
Open

Cannot edit comments #904

endorama opened this issue Oct 21, 2020 · 2 comments

Comments

@endorama
Copy link

endorama commented Oct 21, 2020

Hello, as a user commenting on talks I would have expected to be able edit my comments.

This does not seems to be the case on https://joind.in

Is this expected? There is a way to edit a comment?

If not, would this be considered an acceptable feature?

@iansltx
Copy link
Contributor

iansltx commented Oct 21, 2020

@endorama At this point comment editability isn't implemented because you want an audit log for that sort of thing, so someone can't go in, say something super offensive, then switch it back later and pretend they never said it...or the opposite for good reviews.

If you're willing to spend the time to add comment version history in a way that's backward compatible on the API side, and expose previous versions of comments in on the web side, I believe we'd accept a PR that allowed editable comments.

@endorama
Copy link
Author

Hi @iansltx thanks for the explanation.

There is a little practical gap though, which is GDPR compliance. By deleting the account the service provider is most probably required (depending on geographical region and some nuances like that, but I'm not a layer) to remove all data associated to an account. I'm not a layer, but I worked on implementing GDPR guidelines so I'm pretty sure of that.
In this regard, misbehaviours may still happen.

Anyway I think keeping the edit history is a very reasonable request. I'm not sure I'll have time to dig into such an extensive feature, but thanks for your answer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants