Reduce the cardinality of request tracing metrics

joinemm · Apr 17, 2024 · 5530123 · 5530123
1 parent 2f3769d
commit 5530123
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/cogs/prometheus.py b/cogs/prometheus.py
@@ -54,7 +54,7 @@ def __init__(self, bot):
         self.outgoing_requests = Counter(
             "miso_outgoing_requests",
             "Aiohttp clientsession total requests per domain.",
-            ["host", "path"],
+            ["host"],
         )
 
     async def cog_load(self):

diff --git a/modules/misobot.py b/modules/misobot.py
@@ -115,9 +115,7 @@ async def get_context(self, message: discord.Message):
     async def request_tracing(self, session, context, params):
         try:
             if prom := self.get_cog("Prometheus"):
-                prom.outgoing_requests.labels(
-                    host=params.url.host, path=params.url.path
-                ).inc()  # type: ignore
+                prom.outgoing_requests.labels(host=params.url.host).inc()  # type: ignore
         except Exception as e:
             logger.warning(f"Unhandled exception in tracing: {e}")