refactor scenarios to add resource sets to tomcat in order to find faces resources #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces resources. changing situations with DirResourceSet. usually, if one of the resources sets is DirResourceSet, nothing is done. however, if this resource set contains BOOT-INF folder, it is necessary to add classpath resource sets.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 5.2.x #1979 +/- ##
============================================
+ Coverage 0 62.49% +62.49%
- Complexity 0 31 +31
============================================
Files 0 100 +100
Lines 0 1637 +1637
Branches 0 165 +165
============================================
+ Hits 0 1023 +1023
- Misses 0 573 +573
- Partials 0 41 +41
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on how we run Spring Boot with Tomcat (packaged jar, packaged war, unpackaged), JsfTomcatLifecycleListener adds resources to enable Tomcat to find Faces resources.
Usually, if one of the resource sets of Tomcat is DirResourceSet, nothing is done because Tomcat can find Faces resources with it. However, if this resource set contains a BOOT-INF folder, it does not contain Faces resources, and it is necessary to add classpath resource sets.
Build of joinfaces-gradle-jar-example creates an empty dir BOOT-INF/classes/META-INF/resources. Tomcat identified this folder as DirResourceSet. It was blocking JsfTomcatLifecycleListener from adding the faces resources folder META-INF/resources.
This PR is a tentative to solve #1969