Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mojarra to 2.3.3.99 #459

Merged
merged 1 commit into from
Apr 13, 2018

Conversation

persapiens
Copy link
Member

No description provided.

@persapiens persapiens added this to the 3.2.0 milestone Apr 13, 2018
@persapiens persapiens self-assigned this Apr 13, 2018
@persapiens persapiens merged commit a24d7b8 into joinfaces:master Apr 13, 2018
@larsgrefer
Copy link
Member

What a strange version number.

@larsgrefer
Copy link
Member

In the MOJARRA_2_3X_ROLLING branch of the mojarra repository 2.3.4 is still the newest version.

@persapiens
Copy link
Member Author

persapiens commented Apr 13, 2018

I agree @larsgrefer . 2.3.3.99 has been just released.

I got runtime error with 2.3.4.: run joinfaces-maven-jar-example with java -jar app.jar and submit button. It happens with java -war app.war too. This error did not occur with 2.3.3.99. That's why I changed mojarra version.

@persapiens
Copy link
Member Author

@larsgrefer, do I release joinfaces 3.2.0 with mojarra 2.3.3.99 today or wait until fixing 2.4.0 issue described above?

@persapiens
Copy link
Member Author

We could stay with mojarra 2.3.3 too...

@larsgrefer
Copy link
Member

According to the commit history of the mojarra git repository, 2.3.3.99 is actually the former 2.4.0-SNAPSHOT.

Let me have a look at the error.

@larsgrefer
Copy link
Member

@persapiens What error did you get?

@persapiens
Copy link
Member Author

persapiens commented Apr 13, 2018

2018-04-13 19:58:12.396 ERROR 9524 --- [io-8080-exec-10] j.e.resource.webcontainer.jsf.context    : java.lang.IllegalArgumentException: Unrecognized Content Type.
	at com.sun.faces.renderkit.RenderKitImpl.createResponseWriter(RenderKitImpl.java:283)
	at com.sun.faces.application.view.FaceletViewHandlingStrategy.createResponseWriter(FaceletViewHandlingStrategy.java:1160)
	at com.sun.faces.application.view.FaceletViewHandlingStrategy.renderView(FaceletViewHandlingStrategy.java:438)
	at com.sun.faces.application.view.MultiViewHandler.renderView(MultiViewHandler.java:194)
	at org.ocpsoft.rewrite.faces.RewriteViewHandler.renderView(RewriteViewHandler.java:196)
	at javax.faces.application.ViewHandlerWrapper.renderView(ViewHandlerWrapper.java:151)
	at com.sun.faces.lifecycle.RenderResponsePhase.execute(RenderResponsePhase.java:126)

@persapiens
Copy link
Member Author

@larsgrefer could you reproduce the error?

@larsgrefer
Copy link
Member

@larsgrefer
Copy link
Member

But we can fix it at our side. I will open a PR for the maven-jar-example.

@larsgrefer
Copy link
Member

@persapiens
Copy link
Member Author

You are unbelievable @larsgrefer .

Thank you very much again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants