Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ConcurrentModificationExceptions with Mojarra and Java 9+ #511

Merged
merged 1 commit into from Jul 17, 2018

Conversation

larsgrefer
Copy link
Member

...when using destruction callbacks on view-scoped beans.

fixes #509

…n using destruction callbacks on view-scoped beans.

fixes joinfaces#509
@larsgrefer larsgrefer added the bug label Jul 14, 2018
@larsgrefer larsgrefer added this to the 3.2.4 milestone Jul 14, 2018
@codecov
Copy link

codecov bot commented Jul 14, 2018

Codecov Report

Merging #511 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #511      +/-   ##
============================================
+ Coverage     92.56%   92.58%   +0.02%     
  Complexity      366      366              
============================================
  Files            61       61              
  Lines           955      958       +3     
  Branches        110      111       +1     
============================================
+ Hits            884      887       +3     
  Misses           53       53              
  Partials         18       18
Impacted Files Coverage Δ Complexity Δ
...g/joinfaces/autoconfigure/viewscope/ViewScope.java 98.66% <100%> (+0.05%) 15 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8774548...c253c6b. Read the comment docs.

@persapiens persapiens merged commit 5615e69 into joinfaces:master Jul 17, 2018
@larsgrefer larsgrefer deleted the fix/gh-509 branch September 19, 2018 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewScope.get throws ConcurrentModificationException on java >= 9
2 participants