Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up app layout #107

Closed
ghost opened this issue Feb 17, 2022 · 0 comments · Fixed by #126
Closed

DRY up app layout #107

ghost opened this issue Feb 17, 2022 · 0 comments · Fixed by #126
Labels
tech dept Removes some technical debt
Milestone
v0.0.4 - Bugfixes...

Comments

@ghost
Copy link

ghost commented Feb 17, 2022

Currently we repeat the same layout container (<rb.Col md={10} lg={8} xl={6}>) in almost all pages. We should move this container to a higher level and then render pages as children inside this container. That way we don't have to repeat it on every page. See Layout Routes in React Router.
@ghost ghost added the tech dept Removes some technical debt label Feb 17, 2022
@ghost ghost added this to the v0.0.4 - User Friendliness Go Up! milestone Feb 17, 2022
@ghost ghost self-assigned this Feb 17, 2022
@ghost ghost mentioned this issue Feb 24, 2022
Merged
@ghost ghost linked a pull request Feb 24, 2022 that will close this issue
refactor: dry up app layout #126
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech dept Removes some technical debt
Projects
JAM
Status: Done ✅
Milestone
v0.0.4 - Bugfixes & Cleanup
Development

Successfully merging a pull request may close this issue.

refactor: dry up app layout joinmarket-webui/jam
1 participant
@dergigi