Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "keep funds in Jam" from scheduler #481

Closed
2 of 3 tasks
dergigi opened this issue Aug 24, 2022 · 3 comments · Fixed by #484
Closed
2 of 3 tasks

Remove "keep funds in Jam" from scheduler #481

dergigi opened this issue Aug 24, 2022 · 3 comments · Fixed by #484
Assignees
Labels
privacy Bad privacy implications

Comments

@dergigi
Copy link
Contributor

dergigi commented Aug 24, 2022

As discussed in Call 22.

  • Remove option to "keep funds in Jam"
  • User has to enter external addresses manually
  • Question: show warning if internal address is used via manual copy-paste?
@dergigi dergigi added the privacy Bad privacy implications label Aug 24, 2022
@dergigi dergigi added this to the v0.1.0 - Tasty Parity milestone Aug 24, 2022
@theborakompanioni theborakompanioni self-assigned this Aug 24, 2022
@theborakompanioni
Copy link
Collaborator

* [ ]  Question: show warning if internal address is used via manual copy-paste?

Voting for "Yes". Would also prevent scheduler from starting, tbh.
But there is only so much we can do.. if a user generates addresses from an xpub, which are not yet "known" to jm,.. this cannot (reasonably) be prevented (and probably shouldn't).

Do you think this is the right time to introduce client-side address validation?
I think (need to verify!) that JM does this too but there is no immediate response when starting the scheduler (it subsequently fails silently).

@dergigi
Copy link
Contributor Author

dergigi commented Aug 24, 2022

Would also prevent scheduler from starting, tbh.

Not sure about that one.

@theborakompanioni
Copy link
Collaborator

Should a warning still be displayed if an "internal" addresses is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
privacy Bad privacy implications
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants