feat(jam): remove "keep funds in jam" #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca30545.
theborakompanioni
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
tACK. ✔️
nit: i18n keys toggle_internal_destination_title and toggle_internal_destination_subtitle present but not used anymore.
Also, next is #438 so the new approach can even be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly resolves #481.
I decided to keep the "internal" functionality for testing purposes, otherwise testing the scheduler on regtest is quite cumbersome. The two toggles are now one, the "internal" functionality is now part of
useInsecureTestingSettings.No other changes except for minor wording changes.