feat: highlight own orders in orderbook #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
added
enhancement
Excellent, I think that makes a lot of sense. 🧐👍 |
dergigi
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #413.
This does not actually display the nickname (counterparty ID), but lets the user highlight his own orders, as the nickname is already shown on the Earn page (see #461).
First attempt was to just filter the orderbook for the users orders by using the nickname as search value.
However, opted for highlighting the row instead, as this provides the functionality to sort the data and provide more insights and better hints about the positions of your own orders within the orderbook. Let me know what you think.
📸