Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abort collaborative transaction #497

Merged
merged 6 commits into from
Sep 16, 2022
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Sep 15, 2022

Closes #269.

Adds the ability to abort a running taker operation.

How to test

  1. Send a collaborative transaction
  2. Try to abort the transaction
  3. Verify that the transaction was aborted and not broadcasted

You might want to watch the logs while testing this feature with npm run regtest:logs:jmwalletd

Question: Currently, the text only says "Are you sure you want to abort the collaborative transaction?"..
Stopping a taker operation might lead to end up wasting a "retry" (when commitment was already sourced).. Should it mention that it might lead to inconveniences if this is used "too much in a row"? How to communicate this best?

@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Sep 15, 2022
@theborakompanioni theborakompanioni self-assigned this Sep 15, 2022
@theborakompanioni theborakompanioni marked this pull request as ready for review September 15, 2022 16:45
@dergigi
Copy link
Contributor

dergigi commented Sep 15, 2022

Question: Currently, the text only says "Are you sure you want to abort the collaborative transaction?"..
Stopping a taker operation might lead to end up wasting a "retry" (when commitment was already sourced).. Should it mention that it might lead to inconveniences if this is used "too much in a row"? How to communicate this best?

Let's leave it as is and see how many users run into these kinds of issues in the wild.

Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tACK ✅

src/components/Send.jsx Outdated Show resolved Hide resolved
@dergigi
Copy link
Contributor

dergigi commented Sep 16, 2022

Notes to self:

  • "Abort" sounds quite drastic, maybe reword to "Cancel"?
  • "Collaborative transaction started" toast seems unnecessary now; remove?

@dergigi dergigi merged commit 80e40ff into master Sep 16, 2022
@dergigi dergigi deleted the stop-collaborative-transaction branch September 16, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to stop a running taker operation
2 participants