Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quick freeze/unfreeze utxos #591

Merged
merged 24 commits into from Feb 8, 2023
Merged

Conversation

theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Jan 9, 2023

Closes #480.
Closes #525.

This PR introduces a way to quickly freeze or unfreeze single UTXOs.

Some decision have been made that differ from the Figma design:

  • using slightly different colors for red and blue, that look good on both, dark and light mode
  • remove "frozen" tag, as snowflake icon indicating "frozen" state is already present
  • "bond" tag renamed to "locked"
  • ordering of columns: quick freeze/unfreeze placed at the front
  • confirmations column is kept, as it is important info that should be quickly available
  • instead of a "temperature indicator" (Font Awesome, CC BY 4.0 License) a "sun" icon (Bitcoin Icons, MIT) is used, in order to avoid license issues

📸 Before/After

Mobile

@theborakompanioni theborakompanioni added enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience labels Jan 9, 2023
@theborakompanioni theborakompanioni self-assigned this Jan 9, 2023
@theborakompanioni theborakompanioni changed the title feat: quick freeze unfreeze utxos feat: quick freeze/unfreeze utxos Jan 9, 2023
@theborakompanioni theborakompanioni force-pushed the feat/quick-freeze-unfreeze-utxos branch 2 times, most recently from 7871cb1 to cf6f78c Compare January 10, 2023 13:39
@theborakompanioni theborakompanioni marked this pull request as ready for review January 10, 2023 13:52
@theborakompanioni
Copy link
Collaborator Author

Q: In order to save some space on mobile devices, should the "quick freeze/unfreeze" button move from it's own column to the position of the "utxo icon" when hovering the row?

ping @editwentyone

@editwentyone
Copy link

@theborakompanioni because there is no hover mode on mobile, we don't need the column with the action icon. we just need the status column with the snowflake. if a user wants to perform an action, he needs to select the row and unveil the action buttons.

@theborakompanioni theborakompanioni marked this pull request as draft January 11, 2023 09:46
@theborakompanioni theborakompanioni requested review from editwentyone and removed request for dergigi January 11, 2023 14:37
@theborakompanioni theborakompanioni marked this pull request as ready for review January 11, 2023 14:39
Copy link
Contributor

@dergigi dergigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like it.

It feels a little unintuitive to me, as I would expect the "freeze" action icon to be the same as the freeze indicator icon, as it is the case with "like" or "favorite" and so on. (Compare with "star" in Gmail's list view, or "read/unread" in ProtonMail's list view, and so on.)

Having a 2nd icon for the action is a bit weird, and having a one column for the state (frozen, not frozen) and one column for the action (freeze, unfreeze) is also unusual. Apologies on my side for bringing this up now, and not earlier in Figma.

That being said, it's a small feature for power-users, and it's good as it is. Tested on desktop and mobile. Let's see what the users say, if anything.

Looks good to me, tACK ✅

@dergigi dergigi merged commit f3f6e84 into master Feb 8, 2023
@dergigi dergigi deleted the feat/quick-freeze-unfreeze-utxos branch February 8, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI/UX Issue related to cosmetics, design, or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: shorten addresses in JarDetailsOverlay Quick freeze/unfreeze in UTXO list
3 participants