-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finch v2 #205
Merged
Merged
Finch v2 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is starting to look really good, got a few things I would like to get done before merging and distributing the update.
|
c6e18a5
to
92e6ad3
Compare
- @finch-graphql/api@2.0.1-alpha.0 - @finch-graphql/browser-polyfill@2.0.1-alpha.0 - @finch-graphql/client@2.0.1-alpha.0 - finch-graphql-devtools@1.5.2 - finch-docs@0.1.0 - finch-typescript-codegen@0.1.1-alpha.0 - @finch-graphql/react@2.0.1-alpha.0 - @finch-graphql/types@2.0.1-alpha.0
- @finch-graphql/api@2.0.3-alpha.0 - @finch-graphql/browser-polyfill@2.0.3-alpha.0 - @finch-graphql/client@2.0.3-alpha.0 - finch-graphql-devtools@1.5.4 - finch-docs@0.1.2 - finch-typescript-codegen@0.1.2-alpha.0 - @finch-graphql/react@2.0.3-alpha.0 - @finch-graphql/types@2.0.3-alpha.0
Playing around with this in the Toucan application. Got this error.
|
Fixed, seems like we had a couple of versions of graphql in the modules. These are all in sync now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR outlines Finch v2, which revamps Finch to allow for things to be split up into smaller modules. This will allow us to have more focused modules, and remove extra dependencies not needed in different areas. For instance, on a website using Finch, you will not need to have the
graphql-middleware
modules, and if your extension that does not usereact
you should not need to install it to use Finch.This is going to change the API of Finch a little, but enough to the point where I think it is useful to make a clean break for v2.
The modules now will all be under the
@finch-graphql
scope and the new packages are:This means savings across the board in terms of package size, and flexibility for new integrations.
Testing
Additional notes
No additional information is given