PR feedback.

joist-orm · May 29, 2024 · 2f4ad35 · 2f4ad35
1 parent ce215c6
commit 2f4ad35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/codegen/src/index.ts b/packages/codegen/src/index.ts
@@ -81,7 +81,7 @@ async function main() {
 
       await writeAlterTables(nonDeferredFks);
 
-      if (setting === "error") hasError ??= true;
+      if (setting === "error") hasError = true;
     } else if (setting === "ignore") {
       // We trust the user to know what they're doing
     }

diff --git a/packages/codegen/src/sortForeignKeys.ts b/packages/codegen/src/sortForeignKeys.ts
@@ -48,15 +48,15 @@ export function sortByNonDeferredForeignKeys(entities: EntityDbMetadata[]): {
   // Then add nullable deps next, as they can be fixed-up
 
   const nullableCycles: string[] = [];
-  const notNullCylces: string[] = [];
+  const notNullCycles: string[] = [];
 
   // If we see `books.author_id`, mark `author.inDegree++`
   entities.forEach((entity) => {
     entity.nonDeferredFks
       .filter((m2o) => m2o.notNull)
       .forEach((m2o) => {
         const added = addDependency(graph, entity, m2o);
-        if (Array.isArray(added)) notNullCylces.push(added.join(" -> "));
+        if (Array.isArray(added)) notNullCycles.push(added.join(" -> "));
       });
   });
 
@@ -93,7 +93,7 @@ export function sortByNonDeferredForeignKeys(entities: EntityDbMetadata[]): {
   // Use a marker value for "cyclic"
   entities.filter((e) => e.nonDeferredFkOrder === -1).forEach((e) => (e.nonDeferredFkOrder = 100_000));
 
-  return { nullableCycles, notNullCycles: notNullCylces };
+  return { nullableCycles, notNullCycles: notNullCycles };
 }
 
 type Node = {